Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPUnit version #19

Merged
merged 5 commits into from
Feb 18, 2021
Merged

Upgrade PHPUnit version #19

merged 5 commits into from
Feb 18, 2021

Conversation

raaaahman
Copy link
Collaborator

@raaaahman raaaahman commented Sep 20, 2020

Update

Since the release of PHP 8, it is not possible to use a single PHPUnit version to test with PHP versions from 5.6 to 8.

We could draw inspiration from:

  • WordPress/wordpress-develop: The WordPress Core team has adapted PHPUnit 7.5 to not break with PHP8.
  • woocommerce/woocommerce: Uses quite the same trick, but goes further into creating its own fork of PHPUnit 7.5
  • Yoast/wordpress-seo: Created a composer package to use different versions of PHPUnit given the PHP version tested.

Changes

Going further

Fixes #12

@jonathanbossenger
Copy link
Collaborator

@raaaahman I'm going to leave this open until we make a call on #18, as that decision might affect this one.

@raaaahman
Copy link
Collaborator Author

@raaaahman I'm going to leave this open until we make a call on #18, as that decision might affect this one.

I don't think so. The tests can run on local environment as well (they couldn't before).

@jonathanbossenger
Copy link
Collaborator

I don't think so. The tests can run on local environment as well (they couldn't before).

Aha, ok thanks. I will do my best to test this out in the coming week.

@raaaahman raaaahman added the [Type] development tools Setting up and cofniguring tools to help with the development process. label Dec 20, 2020
@danbilauca danbilauca self-assigned this Feb 14, 2021
@danbilauca danbilauca merged commit 974458f into develop Feb 18, 2021
@danbilauca danbilauca deleted the upgrade-phpunit branch February 18, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] development tools Setting up and cofniguring tools to help with the development process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants