Fix JavaScript linting issues #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
approved these changes
Apr 2, 2023
johnhooks
approved these changes
Apr 2, 2023
johnhooks
approved these changes
Apr 2, 2023
|
@Sephsekla could you please approve this one? Unfortunately, it doesn't need to be approved before I sync the pr with the repo, it has to be done later or we are forced to do it in two steps |
Sephsekla
approved these changes
Apr 3, 2023
|
@erikyo What changed between merging this branch and the ESLint issue? There wasn't a problem with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As @johnhooks reported, there have been problems with linting that need to be resolved, perhaps due to some updates that have been made to the eslint rules over time.
Why?
Will close this issue Fix JavaScript linting issues #208