Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187 Release action #240

Merged
merged 7 commits into from
Apr 5, 2023
Merged

187 Release action #240

merged 7 commits into from
Apr 5, 2023

Conversation

Sephsekla
Copy link
Collaborator

@Sephsekla Sephsekla commented Apr 5, 2023

What?

Create a GitHub action to create a release for a tag, and upload asset files.

Why?

Resolves #187

How?

This PR creates a new GitHub workflow, which will run when a tag is created:

  • Checkout the tag
  • Setup node (as in the build workflow)
  • Build the assets
  • Create a zip folder (excluding certain files using .distignore)
  • Create a new release for the tag and attach the zip

Testing Instructions

Screenshots or screencast

@Sephsekla Sephsekla mentioned this pull request Apr 5, 2023
@johnhooks
Copy link
Collaborator

johnhooks commented Apr 5, 2023

@Sephsekla what are the conditions you would like to trigger this workflow? Scratch that, I took a look at the workflow file.

@Sephsekla Sephsekla self-assigned this Apr 5, 2023
@Sephsekla
Copy link
Collaborator Author

@johnhooks right now I'm thinking that on tag, we should checkout the code, build, remove certain folders (e.g. node_modules, .github), and then zip.

Then create a new release and attach using https://github.com/softprops/action-gh-release

@johnhooks
Copy link
Collaborator

Sounds like a solid plan to me. I'm working on a WordPress Playground, it could be redeployed in this same workflow.

Aside: It will be nice to have build removed.

@Sephsekla Sephsekla added the [Type] Project Management Meta-issues related to WP Notify project management. label Apr 5, 2023
@Sephsekla Sephsekla marked this pull request as ready for review April 5, 2023 13:16
Copy link
Collaborator

@johnhooks johnhooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sephsekla This looks great.

Is the PHP environment setup required to properly build the release? As far as I can tell it isn't, but wanted to double check.

@Sephsekla
Copy link
Collaborator Author

Is the PHP environment setup required to properly build the release? As far as I can tell it isn't, but wanted to double check.

At the moment we only use composer for devDependencies and testing, so it shouldn't be necessary for release. That might change in future though, we'll need to keep an eye out.

@Sephsekla Sephsekla added this to the 0.2.0 milestone Apr 5, 2023
@Sephsekla Sephsekla merged commit 2398383 into develop Apr 5, 2023
@Sephsekla Sephsekla deleted the 187-release-action branch April 5, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to WP Notify project management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a GitHub action to build scripts and styles when a new release is tagged
2 participants