Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add typescript #248

Merged

Conversation

johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 7, 2023

What?

Add typescript to enable JSDoc typing of the JavaScript code base. The @wordpress/eslint-plugin docs state that adding typescript will enable the proper ESLint configuration for importing JSDoc types between files.

Why?

Proper typing greatly enhances IDE autocomplete and API discovery .

Typing will also help catch errors.

@johnhooks johnhooks requested a review from erikyo April 7, 2023 17:02
@johnhooks johnhooks added the [Type] development tools Setting up and cofniguring tools to help with the development process. label Apr 7, 2023
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnhooks johnhooks merged commit 29d9113 into WordPress:develop Apr 7, 2023
@johnhooks johnhooks deleted the build/prepare-to-add-js-types branch April 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] development tools Setting up and cofniguring tools to help with the development process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants