ci: remove php 7.2 add 8.1 and 8.2 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
added
the
[Type] development tools
johnhooks
force-pushed
the
ci/remove-php-72
branch
from
6a884f4 to
7ab6e28
Compare
|
@Sephsekla we need your review on this one. |
This was referenced Apr 12, 2023
Sephsekla
previously approved these changes
Apr 13, 2023
|
@Sephsekla absolutely I will add 8.2. Also I think you can feel comfortable dropping 7.2, WP's minimum requirement right now is 7.4 |
Sephsekla
previously approved these changes
Apr 13, 2023
|
@Sephsekla I can't squash and merge it. Do you think @erikyo and I could have permissions to override the checks? They are super helpful in most context, but there have been a lot of situations like this that we haven't be able to override them when necessary. |
johnhooks
changed the title
johnhooks
force-pushed
the
ci/remove-php-72
branch
from
7e2802a to
ab85fc7
Compare
Sephsekla
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove PHP 7.2 from CI
test-suite.ymlworkflow.Add PHP 8.1 and 8.2 to CI
test-suite.ymlworkflow.Also
lint-stagedformatted the yaml files to match the prettier rules for yaml, which uses 4 spaces for tabs.Also remove
set-output, there was a warning it is depreciated and will be removed soon.Why?
The plugin header specifies minimum PHP support is 7.4.