#40 Sender instance passed to the Factory #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaaahman
reviewed
Mar 1, 2021
includes/Factory.php
Outdated
|
|
||
| $message = $this->message_factory->create( $message_args ); | ||
| [ $message_args, $recipients_args, $sender_args ] = $this->validate( $args ); |
There was a problem hiding this comment.
Short array syntax is not in the WordPress coding standards...
We should configure the PHP Code Sniffer to help us with these standards.
There was a problem hiding this comment.
I've fixed it by using array
includes/senders/SenderFactory.php
Outdated
| * | ||
| * @return WPNotify_Sender | ||
| */ | ||
| public function create( string $name ): WPNotify_Sender; |
There was a problem hiding this comment.
I'm not sure if we should use static type hinting or not.
What would be the benefits in your opinion?
There was a problem hiding this comment.
yep, fixed it by removing it
Comment on lines
+8
to
+21
| $vendor_sender = $this->createMock( 'WPNotify_Sender' ); | ||
|
|
||
| $message_factory = $this->getMockBuilder( 'WPNotify_MessageFactory' ) | ||
| ->setMethods( array( 'create', 'accepts' ) ) | ||
| ->getMock(); | ||
|
|
||
| $message_factory->method( 'create' )->willReturn( $this->createMock( 'WPNotify_Message' ) ); | ||
| $message_factory->method( 'accepts' )->willReturn( true ); | ||
|
|
||
| $sender_factory = $this->getMockBuilder( 'WPNotify_SenderFactory' ) | ||
| ->setMethods( array( 'create' ) ) | ||
| ->getMock(); | ||
|
|
||
| $sender_factory->method( 'create' )->willReturn( $this->createMock( 'WPNotify_Sender' ) ); |
There was a problem hiding this comment.
Good. With all these mocks, you won't have to rewrite your test each time we change the code of any of these factories.
raaaahman
added
[Scope] Model
raaaahman
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chosen to implement a Sender Factory and send it along to Factory's constructor in order to have code consistency and have it processed/validated by Factory's logic.