Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/notification Design implementation (follow-up of #66) #67

Merged
merged 23 commits into from
Jun 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
43cfb6d
moving the design to the WordPress plugin
erikyo May 15, 2022
199b39b
WIP (add notification react component)
erikyo May 15, 2022
158797e
updated style + build
erikyo May 15, 2022
9edb378
cherry-pick commit 0e12b2ef7a40e6edadc1c9e2ac3d3fff3ec8fcdd
erikyo May 16, 2022
5a57b37
add some clarification comments
erikyo May 16, 2022
66e06c8
cherry-pick @bacoords d6cc7e9b commit d6cc7e9bf927179fce0a8f0164683f8…
erikyo May 16, 2022
9c8e23a
migrates settings page to plugin
bacoords May 17, 2022
4db8995
Merge pull request #1 from erikyo/migrate-settings-page
erikyo May 17, 2022
ff92052
expose notify function to window
erikyo May 17, 2022
e78b4cb
add the link to the repo, fix notification markup and some other litt…
erikyo May 18, 2022
8160c0e
fix a couple of ui bugs like the "old" notifications inside the new o…
erikyo May 20, 2022
0462c4f
adds git pre-commit hooks
erikyo May 20, 2022
1e1ab73
moves the sample notification into the worker
bacoords May 23, 2022
7624e55
removes demo div element
bacoords May 23, 2022
307bd09
Merge pull request #2 from erikyo/fix/design_implementation
erikyo May 23, 2022
1627c76
adds separate wpnotify metabox
bacoords May 23, 2022
cbc6fdd
Merge pull request #3 from erikyo/fix/adds_metabox
erikyo May 23, 2022
0ec3e57
fix some changed refs
erikyo May 24, 2022
1a3f211
remove the demo buttons at the top of the dashboard
erikyo May 24, 2022
ac74e33
prepare animations
erikyo May 24, 2022
c24c9ea
Notification container class
erikyo May 24, 2022
51df183
moves defaultProps inside the dashNotice class
erikyo May 25, 2022
582e360
Restores the demo content of the previous PR
erikyo May 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# This file is for unifying the coding style for different editors and IDEs
# editorconfig.org

# WordPress Coding Standards
# https://make.wordpress.org/core/handbook/coding-standards/

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 2
tab_width = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true

[*.php]
indent_style = tab

[*.txt]
trim_trailing_whitespace = false

[*.{md,json,yml}]
trim_trailing_whitespace = false

[*.json]
indent_style = tab
indent_size = 4
tab_width = 4
29 changes: 29 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/**
* Set WordPress presets
*/

const eslintConfig = {
extends: ["plugin:@wordpress/eslint-plugin/recommended"],
rules: {
"padding-line-between-statements": [
"error",
{
blankLine: "always",
next: ["function", "const", "let", "var"],
prev: "return",
},
],
"max-len": ["error", { code: 160, tabWidth: 12 }],
"prettier/prettier": ["error", { endOfLine: "auto" }],
},
};

eslintConfig.parserOptions = {
ecmaVersion: 6,
env: { es6: true },
babelOptions: {
presets: [require.resolve("@wordpress/babel-preset-default")],
},
};

module.exports = eslintConfig;
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
# OS fixes
.DS_Store

/node_modules/
/vendor/
.phpunit.result.cache
Binary file added .nvmrc
Binary file not shown.
1 change: 1 addition & 0 deletions build/wp-notify.asset.php
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<?php return array('dependencies' => array('react', 'wp-element'), 'version' => 'a44fe8378d47ad5d074f6c42291258d8');
2 changes: 2 additions & 0 deletions build/wp-notify.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions build/wp-notify.js

Large diffs are not rendered by default.

23 changes: 21 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"phpunit/phpunit": "^7",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
"wp-coding-standards/wpcs": "^2.3",
"wp-phpunit/wp-phpunit": "^5.6"
"wp-phpunit/wp-phpunit": "^5.6",
"brainmaestro/composer-git-hooks": "^2.8"
},
"license": "GPL-2.0-or-later",
"authors": [
Expand All @@ -18,6 +19,24 @@
"minimum-stability": "dev",
"prefer-stable": true,
"scripts": {
"lint": "vendor/squizlabs/php_codesniffer/bin/phpcs --report=summary,source"
"lint": "vendor/bin/phpcs --standard=phpcs.xml.dist --report=summary,source includes/",
"lint-fix": "vendor/bin/phpcbf --standard=phpcs.xml.dist includes/",
"cghooks": "vendor/bin/cghooks",
"phpcs-fix": "phpcbf --standard=phpcs.xml.dist includes/",
"post-install-cmd": "cghooks add --ignore-lock",
"post-update-cmd": "cghooks update"
},
"extra": {
"hooks": {
"pre-commit": [
"composer lint && npm run build"
],
"post-merge": "composer install"
}
},
"config": {
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
}
}
}
Loading