Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69 update plugin name #70

Merged
merged 4 commits into from
Jun 8, 2022
Merged

#69 update plugin name #70

merged 4 commits into from
Jun 8, 2022

Conversation

Sephsekla
Copy link
Collaborator

#69 Updates the plugin name and also the composer.json name field.

@erikyo
Copy link
Collaborator

erikyo commented Jun 1, 2022

another way to fix could be to add the version > 1.0.1 in this way

/**
 * Plugin Name:       WP Notify
 * Plugin URI:        URI
 * Description:       DESC
 * Version:           1.0.1
 * Requires at least: 6.0
 * Requires PHP:      7.1.0
 * Author:            AUTHOR
 * Author URI:        AUTHOR_URI
 * License:           GPL v2 or later
 * License URI:       https://www.gnu.org/licenses/gpl-2.0.html
 * Text Domain:       wp-notify
 */

@Sephsekla
Copy link
Collaborator Author

I'd personally rather avoid any ambiguity at all, since they're not remotely the same plugin.

@jonathanbossenger what do you think?

@jonathanbossenger
Copy link
Collaborator

Just thinking out loud, should we also update the composer.json name to wordpress/wp-feature-notifications.

WP Notify was just a generica name we chose for the project, but WP Feature Notifications more accurately describes the project and prevents any future conflicts. It also ties in nicely with our Slack channel name.

@Sephsekla
Copy link
Collaborator Author

That works for me, I'll update this a bit later on today.

@jonathanbossenger
Copy link
Collaborator

While we're at it, we might as well rename the main plugin file to wp-feature-notifications.php as well

@Sephsekla
Copy link
Collaborator Author

Sure, l'll handle this and see if there's anything else that will want changing in line with this.

@erikyo erikyo added the documentation Improvements or additions to documentation label Jun 4, 2022
@Sephsekla
Copy link
Collaborator Author

Sorry all, I've been busy with flights etc this week. I'll try and get this sorted shortly.

@jonathanbossenger jonathanbossenger merged commit c0cb75c into develop Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants