Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit link typo in readme.txt #90

Closed
wants to merge 1 commit into from
Closed

Edit link typo in readme.txt #90

wants to merge 1 commit into from

Conversation

SavPhill
Copy link

Edited a typo in the Github link title and changed the ordered list to ascending numbers

Edited a typo in the Github link and the numerics in the ordered list.
@bacoords
Copy link
Collaborator

I'm actually a fan of sticking to the current ordered list method in markdown files (1. 1. 1. 1. etc) because it makes it much easier to add/move new items without having to manually renumber. It also make visual diffs a lot cleaner.

Not sure what best practices are here, though.

@Sephsekla
Copy link
Collaborator

I'm in agreement on the list items. Markdown makes it unnecessary to worry about the numbers, so why add that worry back?

@bacoords
Copy link
Collaborator

The other fixes were just merged in #79 , so I vote to close this, but would encourage @SavPhill to contribute again!

@Sephsekla
Copy link
Collaborator

Agreed, it's really great to see someone new get stuck in!

@erikyo
Copy link
Collaborator

erikyo commented Jun 14, 2022

closing in favor of #79

@erikyo erikyo closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants