-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refreshing preview SidePanel storybook examples #3056
Open
williamjstanton
wants to merge
21
commits into
Workday:master
Choose a base branch
from
williamjstanton:william-sidepanel-nav-example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: Refreshing preview SidePanel storybook examples #3056
williamjstanton
wants to merge
21
commits into
Workday:master
from
williamjstanton:william-sidepanel-nav-example
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing some label problems in SidePanel with labelProps. Also deleting old style functions. Also deleting old data structures.
Also documented the issue in comments for devs.
Also fixed some paragraph styling in other examples.
Also missed removing the ARIA button role from SecondaryButton in the Variant example.
Workday/canvas-kit Run #8061
Run Properties:
|
Project |
Workday/canvas-kit
|
Branch Review |
william-sidepanel-nav-example
|
Run status |
Passed #8061
|
Run duration | 03m 55s |
Commit |
d8ce2bd004 ℹ️: Merge edf126db25f90696e7ac0d3d7beb11da5e25ac41 into 9a6f57a9daed9618b7de81ff67ec...
|
Committer | William Stanton |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
31
|
Pending |
24
|
Skipped |
0
|
Passing |
1093
|
View all changes introduced in this branch ↗︎ |
UI Coverage
21.95%
|
|
---|---|
Untested elements |
1623
|
Tested elements |
454
|
Accessibility
99.17%
|
|
---|---|
Failed rules |
5 critical
5 serious
0 moderate
2 minor
|
Failed elements |
178
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I recently reviewed the accessibility of a bespoke team's work, using the Canvas SidePanel component for their navigation.
Release Category
Documentation > Storybook examples
Release Note
Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Start here: modules/react/_examples/stories/mdx/examples/SidePanelWithNavigation.tsx
Updated docs: modules/react/_examples/stories/mdx/SidePanel.mdx
modules/react/_examples/stories/mdx/examples/SidePanelWithOverlay.tsx
Important change to external
controlProps
: modules/preview-react/side-panel/stories/examples/ExternalControl.tsxNotes about accessibility: modules/preview-react/side-panel/stories/SidePanel.mdx
modules/preview-react/side-panel/stories/examples/Basic.tsx
And all other examples in this folder.
Areas for Feedback? (optional)
I'd like some feedback about CSS styling and my use of the new tokens system.
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)