Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

CJ4: Quality of life improvements #480

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Conversation

J-Hoskin
Copy link
Member

@J-Hoskin J-Hoskin commented Oct 31, 2020

Bug Fixes

  • Fixed altimeter rounding bug on whole numbers
  • Fixed incorrect estimated fuel at destination on FMS text

Cameras:

  • Added 6 new passenger cameras
  • Added 2 new external cameras
  • Improved cockpit related cameras to be more accurate

Buttons/Switches/Knobs:

  • Added partial animation functionality to the cockpit speaker mute button (model does not have proper button animation)
  • Add partial animation functionality to oxygen mask mic buttons (model does not have proper button animation)
  • Added animation functionality to oxygen control knob
  • Add animation functionality to tail anti-ice buttons
  • Pressoure source knob set to NORM by default
  • Add functionality to DCP CCP button with WIP CCP Menu

MFD/PFD

  • Changed default memory pre-sets to be more useful and what was recommended by K20017
  • Add partial functionality to the PFD Lower Menu in the MFD Lower Menu
  • Improved styling of PFD and MFD menus to be more realistic and improve underlying code
  • Added Destination airport elevation to PFD REFS menu
  • Added TERR/WX selection from PFD Lower Menu

this.addTitle("BRG PTR 1", this.textSize, 0.5);
this.addRadio("OFF", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
this.addRadio("FMS1", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
this.addRadioRange("VOR1", this.textSize, 108, 117.95, 0.005, [CJ4_PopupMenu_Key.BRG_PTR1_SRC, CJ4_PopupMenu_Key.BRG_VOR1_FREQ]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not appear to be synchronized with the bearing pointer changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this branch off 0.6.5. Are bearing pointers on the pre-release yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were already on main, but this code looks moved entirely from the original location, so it may not be picking up the conflict.

These lines now should be like this:

            this.beginSection();
            {
                this.addTitle("BRG PTR 1", this.textSize, 0.5);
                this.addRadio("OFF", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
                this.addRadio("FMS1", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
                this.addRadio("VOR1", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
                this.addRadio("ADF1", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR1_SRC]);
            }
            this.endSection();
            this.beginSection();
            {
                this.addTitle("BRG PTR 2", this.textSize, 0.5);
                this.addRadio("OFF", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR2_SRC]);
                this.addRadio("VOR2", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR2_SRC]);
                this.addRadio("ADF2", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR2_SRC]);
            }
            this.endSection();

Check the original location this stuff was copied from to make sure you picked everything you need up.

{
this.addTitle("BRG PTR 2", this.textSize, 0.5);
this.addRadio("OFF", this.textSize, [CJ4_PopupMenu_Key.BRG_PTR2_SRC]);
this.addRadioRange("VOR2", this.textSize, 108, 117.95, 0.005, [CJ4_PopupMenu_Key.BRG_PTR2_SRC, CJ4_PopupMenu_Key.BRG_VOR2_FREQ]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, missing bearing pointer changes.

@J-Hoskin J-Hoskin changed the title Quality of life improvements CJ4: Quality of life improvements Nov 2, 2020
@mattnischan mattnischan force-pushed the releases/cj4-v0.6.5-pre branch from 05409a8 to 3e100ee Compare November 4, 2020 18:49
@J-Hoskin J-Hoskin mentioned this pull request Nov 5, 2020
Base automatically changed from releases/cj4-v0.6.5-pre to main November 5, 2020 23:00
@J-Hoskin
Copy link
Member Author

J-Hoskin commented Nov 7, 2020

Ready for Q&A

@dga711
Copy link
Member

dga711 commented Nov 7, 2020

You added LOD00 and LOD01 GLTF. What are the changes there? I am worried it will overwrite the LOD00 already in main for the lower panel lighting

@J-Hoskin
Copy link
Member Author

J-Hoskin commented Nov 7, 2020

@dga711 did you change the LOD? Cause in my tests, the lower CCP was lit up still

@dga711
Copy link
Member

dga711 commented Nov 7, 2020

@dga711 did you change the LOD? Cause in my tests, the lower CCP was lit up still

@J-Hoskin yeah I changed lod00 to make the emissive work correctly for lower ccp
What are your changes to lod00 and why lod01?

@J-Hoskin
Copy link
Member Author

J-Hoskin commented Nov 7, 2020

@dga711 I don't know the difference between LODs but buttons/switches are declared in both, so I changed the definitions for the COM1 Tune and Cockpit speaker mute buttons.

The lower CCP was lit in both tests I did on each branch. You can check to see.

@dga711 dga711 force-pushed the features/QoL-improvements branch from 95b1770 to c3aa3b8 Compare November 14, 2020 21:32
@dga711 dga711 force-pushed the features/QoL-improvements branch from c3aa3b8 to 981d1dc Compare November 14, 2020 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants