Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_891] give more space for Files column #933

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

adam-tokarski
Copy link
Contributor

Fixes #891

Provided changes:

  • the Files column is widened by 2 chars (in origin issue it was suggested 1 would be enough though, but 2 seems like nicely fitting as well)
  • some consts are provided to store these columns width magic numbers to ease work a little bit
  • .gitignore was adjusted - I've regenerated it using https://www.toptal.com/developers/gitignore/ and provided back some already existing ones. Some, like .commit_message or node_modules, were removed as seems like some leftovers. Also, .idea is added for cases of usage Jetbrains tools.

@XAMPPRocky
Copy link
Owner

Thank you for your PR! However it seems that the files output is currently misaligned. Would you be able to address that?

Screenshot 2022-08-15 at 08 51 28

@adam-tokarski
Copy link
Contributor Author

Will do but not earlier than in 2 weeks as I'm off now. Thanks for catching that issue!

+ put columns width magic numbers into some consts
New consts for that are moved into dedicated consts file
@adam-tokarski
Copy link
Contributor Author

Right. Apparently I've been checking that using wrong version of tokei, my bad.

There is updated version - please especially check whether I handled properly moving these consts to dedicated file. @XAMPPRocky

@adam-tokarski
Copy link
Contributor Author

@XAMPPRocky I'm pinging you, just in case you have missed my last changes. Also, I guess you're very busy, so do not want to disturb you.

@adam-tokarski
Copy link
Contributor Author

@XAMPPRocky ping 😺

@Sigmanificient
Copy link

Still waiting on that one 😅

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 1428a7e into XAMPPRocky:master Jun 18, 2024
71 checks passed
@adam-tokarski
Copy link
Contributor Author

@XAMPPRocky
Hmm, it seems that this is failing on release-plz action with

ERROR Cargo.lock is present in your .gitignore and is also committed. Remove it from your repository or from your .gitignore file.

Should we preserve Cargo.lock here? If so, I would need to remove that from .gitignore as it's suggested.

@XAMPPRocky
Copy link
Owner

Should we preserve Cargo.lock here? If so, I would need to remove that from .gitignore as it's suggested.

Yes Cargo.lock should be committed as this is a binary crate.

@adam-tokarski
Copy link
Contributor Author

Yes Cargo.lock should be committed as this is a binary crate.

So there is #1115 to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Line overflow on large quantity of code
3 participants