Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit connection #1609

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Rate limit connection #1609

merged 2 commits into from
Nov 29, 2024

Conversation

opieters
Copy link
Contributor

Description

Fix consistency issue: when using async with self.xknx.management.connection, it was not possible to add a rate limit, though the underlying connect function supports this. This PR makes both ways of creating a connection consistent.

I did not add a changelog update, since there's no release yet which supports rate limiting connections.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (5cc4078) to head (12ecd9c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         158      158           
  Lines       10617    10617           
=======================================
  Hits        10290    10290           
  Misses        327      327           
Files with missing lines Coverage Δ
xknx/management/management.py 91.08% <100.00%> (ø)

Copy link
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@farmio farmio merged commit b1fd243 into XKNX:main Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants