Add oscillation to fan #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmio
requested changes
Feb 4, 2021
docs/fan.md
Outdated
| - `group_address` is the KNX group address of the fan speed. Used for sending. | ||
| - `group_address_state` is the KNX group address of the fan speed state. Used for updating and reading state. | ||
| - `group_address_oscillation` is the KNX group address of the oscillation. Used for sending. *DPT 1.001* | ||
| - `group_address_oscillation_state` is the KNX group address of the fan oscillation state. Used for updating and reading state. *DPT 1.001* | ||
| - `device_updated_cb` awaitable callback for each update. | ||
| - `max_step` Maximum step amount for fans which are controlled with steps and not percentage. |
There was a problem hiding this comment.
Please add a note like "if None percentage is used" and "Default: None" so it is clear when DPT 5.001 or 5.010 is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HA supports turning the oscillation of the fan on or off. https://developers.home-assistant.io/docs/core/entity/fan/
Furthermore in #466 there was the request to control the oscillation via switch DPT 1.001
Fixes # (issue)
Type of change
Checklist: