Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Dynamic NFT #1525

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: Support Dynamic NFT #1525

wants to merge 5 commits into from

Conversation

cindyyan317
Copy link
Collaborator

@cindyyan317 cindyyan317 marked this pull request as draft July 9, 2024 12:45
@shawnxie999 shawnxie999 mentioned this pull request Jul 16, 2024
Open
4 tasks
cindyyan317
cindyyan317 commented Jul 23, 2024
View reviewed changes
conanfile.py Outdated
@@ -28,7 +28,8 @@ class Clio(ConanFile):
'protobuf/3.21.9',
'grpc/1.50.1',
'openssl/1.1.1u',
'xrpl/2.3.0-b1',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this change. DNFT will be merged after libxrpl gets updated.

@cindyyan317 cindyyan317 marked this pull request as ready for review July 23, 2024 15:28
godexsoft
godexsoft requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few nits 👍

src/data/CassandraBackend.hpp Outdated Show resolved Hide resolved
src/data/CassandraBackend.hpp Show resolved Hide resolved
src/etl/NFTHelpers.cpp Outdated Show resolved Hide resolved
src/etl/NFTHelpers.cpp Show resolved Hide resolved
src/etl/impl/LedgerLoader.hpp Show resolved Hide resolved
src/etl/impl/LedgerLoader.hpp Outdated Show resolved Hide resolved
@cindyyan317 cindyyan317 force-pushed the DNFT branch 3 times, most recently from a6b7569 to 1edb890 Compare July 25, 2024 10:27
@cindyyan317 cindyyan317 changed the title Support Dynamic NFT feat: Support Dynamic NFT Jul 25, 2024
@kennyzlei kennyzlei linked an issue Aug 6, 2024 that may be closed by this pull request
Support DynamicNFT XLS-46 #1471
Open
shawnxie999
shawnxie999 previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cindyyan317
Copy link
Collaborator Author

After XRPLF/rippled#5048 is merged, we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuznetsss kuznetsss kuznetsss left review comments

@shawnxie999 shawnxie999 shawnxie999 left review comments

@godexsoft godexsoft Awaiting requested review from godexsoft

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DynamicNFT XLS-46
4 participants
@cindyyan317 @godexsoft @kuznetsss @shawnxie999