feat: Graceful shutdown #1801
Draft
feat: Graceful shutdown #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdown_with_new_server
…tdown_with_new_server
kuznetsss
force-pushed
the
442_Graceful_shutdown_with_new_server
branch
from
77db7fe to
7062d40
Compare
godexsoft
requested changes
Dec 23, 2024
| */ | ||
| class Stopper { | ||
| boost::asio::io_context ctx_; | ||
| std::thread worker_; |
There was a problem hiding this comment.
Should we use async framework here or is this deliberately not using it?
Comment on lines
+165
to
+169
| auto connection = wsConnectionBuilder_.connect(yield); | ||
| if (not connection) { | ||
| handleError(connection.error(), yield); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| auto connection = wsConnectionBuilder_.connect(yield); | |
| if (not connection) { | |
| handleError(connection.error(), yield); | |
| return; | |
| } | |
| if (auto connection = wsConnectionBuilder_.connect(yield); connection) { | |
| wsConnection_ = std::move(connection).value(); | |
| } else { | |
| handleError(connection.error(), yield); | |
| return; | |
| } |
This scopes connection so that there is no way anyone can use it after we moved from it, even if they wanted to
| return; | ||
| } | ||
| auto const& subscribeCommand = getSubscribeCommandJson(); | ||
| auto const writeErrorOpt = wsConnection_->write(subscribeCommand, yield, wsTimeout_); |
Comment on lines
+187
to
197
| auto const message = wsConnection_->read(yield, wsTimeout_); | ||
| if (not message) { | ||
| handleError(message.error(), yield); | ||
| return; | ||
| } | ||
|
|
||
| auto const handleErrorOpt = handleMessage(message.value()); | ||
| if (handleErrorOpt) { | ||
| handleError(handleErrorOpt.value(), yield); | ||
| return; | ||
| } | ||
| auto const handleErrorOpt = handleMessage(message.value()); | ||
| if (handleErrorOpt) { | ||
| handleError(handleErrorOpt.value(), yield); | ||
| return; | ||
| } |
| boost::asio::steady_timer timer{yield.get_executor(), std::chrono::steady_clock::duration::max()}; | ||
| onStopReady_.connect([&timer]() { timer.cancel(); }); | ||
| boost::system::error_code error; | ||
| if (not*stopped_) |
There was a problem hiding this comment.
Maybe in this case !*stopped_ is better? 😃
| { | ||
| boost::asio::steady_timer timer{yield.get_executor(), std::chrono::steady_clock::duration::max()}; | ||
| onStopReady_.connect([&timer]() { timer.cancel(); }); | ||
| boost::system::error_code error; |
There was a problem hiding this comment.
Should we do anything at all about this error if it's set?
| if (connectionHandler_.isStopping()) { | ||
| boost::asio::spawn( | ||
| ctx_.get(), | ||
| [connection = std::move(connectionExpected).value()](boost::asio::yield_context yield) { |
There was a problem hiding this comment.
nit: Here and other places - we usually pass yield as auto in lambdas
| ); | ||
| serverStopped.get(); | ||
| balancerStopped.get(); | ||
| // etl->stop(); |
There was a problem hiding this comment.
Are these left intentionally for future or just forgotten to be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #442. This is a WIP PR containing current state of graceful shutdown.