[FOLD] Stop taskQueue at shutdown

XRPLF · Mar 6, 2020 · 15850b5 · 15850b5
1 parent 2674ce0
commit 15850b5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/ripple/nodestore/impl/DatabaseShardImp.cpp b/src/ripple/nodestore/impl/DatabaseShardImp.cpp
@@ -59,13 +59,7 @@ DatabaseShardImp::DatabaseShardImp(
 
 DatabaseShardImp::~DatabaseShardImp()
 {
-    if (!isStopping())
-        onStop();
-
-    // Close backend databases before destroying the context
-    std::lock_guard lock(mutex_);
-    shards_.clear();
-    ctx_.reset();
+    onStop();
 }
 
 bool
@@ -660,14 +654,20 @@ DatabaseShardImp::validate()
 void
 DatabaseShardImp::onStop()
 {
+    Database::onStop();
+
     {
         std::lock_guard lock(mutex_);
+
+        // Notify and destroy shards
         for (auto const& e : shards_)
             if (e.second.shard)
                 e.second.shard->stop();
+        shards_.clear();
     }
 
-    Database::onStop();
+    // Stop queued tasks
+    taskQueue_->pause();
 }
 
 void

diff --git a/src/ripple/nodestore/impl/TaskQueue.h b/src/ripple/nodestore/impl/TaskQueue.h
@@ -40,6 +40,9 @@ class TaskQueue : private Workers::Callback
     void
     addTask(std::function<void()> task);
 
+    void
+    pause() {workers_.pauseAllThreadsAndWait();}
+
 private:
     std::mutex mutex_;
     Workers workers_;