[FOLD] Remove per-256 response in 'feature' RPC

XRPLF · Jun 19, 2020 · 2bc3898 · 2bc3898
1 parent 9f6aefc
commit 2bc3898
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/ripple/app/misc/impl/AmendmentTable.cpp b/src/ripple/app/misc/impl/AmendmentTable.cpp
@@ -641,10 +641,7 @@ AmendmentTableImpl::injectJson(
         v[jss::validations] = votesTotal;
 
         if (votesNeeded)
-        {
-            v[jss::vote] = votesFor * 256 / votesNeeded;
             v[jss::threshold] = votesNeeded;
-        }
     }
 }
 

diff --git a/src/test/rpc/Feature_test.cpp b/src/test/rpc/Feature_test.cpp
@@ -177,9 +177,6 @@ class Feature_test : public beast::unit_test::suite
             BEAST_EXPECTS(
                 !feature.isMember(jss::validations),
                 feature[jss::name].asString() + " validations");
-            BEAST_EXPECTS(
-                !feature.isMember(jss::vote),
-                feature[jss::name].asString() + " vote");
         }
 
         auto majorities = getMajorityAmendments(*env.closed());
@@ -218,10 +215,10 @@ class Feature_test : public beast::unit_test::suite
             BEAST_EXPECTS(
                 feature.isMember(jss::validations),
                 feature[jss::name].asString() + " validations");
-            BEAST_EXPECTS(
-                feature.isMember(jss::vote),
-                feature[jss::name].asString() + " vote");
-            BEAST_EXPECT(feature[jss::vote] == 256);
+
+            BEAST_EXPECT(feature[jss::count] == 1);
+            BEAST_EXPECT(feature[jss::threshold] == 1);
+            BEAST_EXPECT(feature[jss::validations] == 1);
             BEAST_EXPECT(feature[jss::majority] == 2740);
         }
     }