Skip to content

Commit

Permalink
Avoid stack overflow on AppVeyor:
Browse files Browse the repository at this point in the history
o Reduce json_reader max recursion, and
o Use a GCE VM for AppVeyor
  • Loading branch information
scottschurr committed Jan 23, 2018
1 parent eaff9a0 commit 620229d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ environment:

# We bundle up protoc.exe and only the parts of boost and openssl we need so
# that it's a small download. We also use appveyor's free cache, avoiding fees
# downloading from S3 each time.
# downloading from S3 each time.
# TODO: script to create this package.
RIPPLED_DEPS_PATH: rippled_deps17.01
RIPPLED_DEPS_URL: https://ripple.github.io/Downloads/appveyor/%RIPPLED_DEPS_PATH%.zip
Expand All @@ -21,6 +21,11 @@ environment:
BOOST_ROOT: C:/%RIPPLED_DEPS_PATH%/boost
OPENSSL_ROOT: C:/%RIPPLED_DEPS_PATH%/openssl

# We've had trouble with AppVeyor apparently not having a stack as large
# as the *nix CI platforms. AppVeyor support suggested that we try
# GCE VMs. The following line is supposed to enable that VM type.
appveyor_build_worker_cloud: gce

matrix:
# This build works, but our current Appveyor config runs matrix builds
# sequentially, and the one build is already slow enough.
Expand Down Expand Up @@ -127,7 +132,7 @@ test_script:
- ps: |
& {
# Run the rippled unit tests
& $exe --unittest --quiet --unittest-log
& $exe --unittest --unittest-log
# https://connect.microsoft.com/PowerShell/feedback/details/751703/option-to-stop-script-if-command-line-exe-fails
if ($LastExitCode -ne 0) { throw "Unit tests failed" }
}
Expand Down
2 changes: 1 addition & 1 deletion src/ripple/json/json_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class Reader
*/
std::string getFormatedErrorMessages () const;

static constexpr unsigned nest_limit {1000};
static constexpr unsigned nest_limit {25};

private:
enum TokenType
Expand Down

0 comments on commit 620229d

Please sign in to comment.