test: Check for some unlikely null dereferences in tests (#5004)

XRPLF · Dec 3, 2024 · 8215c60 · 8215c60
1 parent d7e9491
commit 8215c60
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/test/jtx/impl/flags.cpp b/src/test/jtx/impl/flags.cpp
@@ -41,7 +41,9 @@ void
 flags::operator()(Env& env) const
 {
     auto const sle = env.le(account_);
-    if (sle->isFieldPresent(sfFlags))
+    if (!sle)
+        env.test.fail();
+    else if (sle->isFieldPresent(sfFlags))
         env.test.expect((sle->getFieldU32(sfFlags) & mask_) == mask_);
     else
         env.test.expect(mask_ == 0);
@@ -51,7 +53,9 @@ void
 nflags::operator()(Env& env) const
 {
     auto const sle = env.le(account_);
-    if (sle->isFieldPresent(sfFlags))
+    if (!sle)
+        env.test.fail();
+    else if (sle->isFieldPresent(sfFlags))
         env.test.expect((sle->getFieldU32(sfFlags) & mask_) == 0);
     else
         env.test.pass();

diff --git a/src/test/rpc/AccountSet_test.cpp b/src/test/rpc/AccountSet_test.cpp
@@ -41,7 +41,7 @@ class AccountSet_test : public beast::unit_test::suite
         env.fund(XRP(10000), noripple(alice));
         // ask for the ledger entry - account root, to check its flags
         auto const jrr = env.le(alice);
-        BEAST_EXPECT((*env.le(alice))[sfFlags] == 0u);
+        BEAST_EXPECT(jrr && jrr->at(sfFlags) == 0u);
     }
 
     void