Skip to content

Commit

Permalink
Add/update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Bronek committed Nov 22, 2023
1 parent 62d51a0 commit b3cb87e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/ripple/app/misc/NetworkOPs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2181,6 +2181,8 @@ NetworkOPsImp::pubValidation(std::shared_ptr<STValidation> const& val)
if (masterKey != signerPublic)
jvObj[jss::master_key] = toBase58(TokenType::NodePublic, masterKey);

// NOTE *seq is a number, but old API versions used string. We replace
// number with a string, based on API version, below.
if (auto const seq = (*val)[~sfLedgerSequence])
jvObj[jss::ledger_index] = *seq;

Expand Down Expand Up @@ -2220,7 +2222,7 @@ NetworkOPsImp::pubValidation(std::shared_ptr<STValidation> const& val)
reserveIncXRP && reserveIncXRP->native())
jvObj[jss::reserve_inc] = reserveIncXRP->xrp().jsonClipped();

// TODO Replace multiObj with jvObj when API versions 1 & 2 are retired
// TODO Replace multiObj with jvObj when API versions 1 is retired
MultiApiJson multiObj{jvObj};
visit<RPC::apiMinimumSupportedVersion, RPC::apiMaximumValidVersion>(
multiObj, //
Expand Down

0 comments on commit b3cb87e

Please sign in to comment.