Skip to content

Commit

Permalink
[FOLD] Review feedback from @gregtatcam:
Browse files Browse the repository at this point in the history
** Do not include this message in the squashed commit message
* Move one of the tests and update a comment.
  • Loading branch information
ximinez committed Mar 24, 2023
1 parent 6a3479a commit f2742cf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/test/app/RCLValidations_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ class RCLValidations_test : public beast::unit_test::suite
*prev, env.app().timeKeeper().closeTime());
// Force a different hash on the first iteration
next->updateSkipList();
BEAST_EXPECT(next->read(keylet::fees()));
if (forceHash)
{
BEAST_EXPECT(next->read(keylet::fees()));
next->setImmutable();
forceHash = false;
}
Expand Down
6 changes: 3 additions & 3 deletions src/test/app/TxQ_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2939,9 +2939,9 @@ class TxQ1_test : public beast::unit_test::suite
// Verify that nothing can be added now that the gap is filled.
env(noop(alice), seq(aliceSeq + 20), ter(telCAN_NOT_QUEUE_FULL));

// Close ledger 6. That removes 6 of alice's transactions,
// but alice adds one more transaction at seq(aliceSeq + 20) so
// we only see a reduction by 5.
// Close ledger 6. That removes some of alice's transactions,
// but alice adds some more transaction(s) so expectedCount
// may not reduce to 8.
env.close();
checkMetrics(__LINE__, env, 9, 50, 6, 5, 256);
BEAST_EXPECT(env.seq(alice) == aliceSeq + 13);
Expand Down

0 comments on commit f2742cf

Please sign in to comment.