Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_objects can't filter by checks #2350

Closed
mDuo13 opened this issue Jan 24, 2018 · 1 comment
Closed

account_objects can't filter by checks #2350

mDuo13 opened this issue Jan 24, 2018 · 1 comment
Assignees

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Jan 24, 2018

The account_objects API method's type field lets you get only objects of a specific type, but it looks like the Checks amendment (PR #2245) doesn't add checks to the list of types you can filter by:

https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/impl/RPCHelpers.cpp#L668-L687

As a result, doing account_objects with "type": "check" has no effect; non-check objects get returned alongside checks.

@scottschurr
Copy link
Collaborator

Great catch, @mDuo13. Thanks.

scottschurr added a commit to scottschurr/rippled that referenced this issue Feb 2, 2018
bachase pushed a commit to bachase/rippled that referenced this issue Feb 3, 2018
bachase pushed a commit to bachase/rippled that referenced this issue Feb 3, 2018
@bachase bachase closed this as completed in 88570df Feb 5, 2018
seelabs pushed a commit to seelabs/rippled that referenced this issue Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants