You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BaseFee is serialized as hex despite being an XRP amount (UInt64)
ReferenceFeeUnits, ReserveBase, and ReserveIncrement are serialized as JSON numbers, not strings as XRP usually is. (This is because they are actually UInt32 types instead of the usual UInt64.)
It would be nice to change the binary format of the FeeSettings object to make it use the proper data type for XRP amounts in all its XRP fields, but that's harder to fix because it would require an amendment.
The text was updated successfully, but these errors were encountered:
Note that with the given data structures the maximum theoretical values for fee settings are, shall we say, strange. The reserve settings, which would make sense to be much larger than the costs of sending a transaction, are more limited.
The
FeeSettings
ledger object type has some weird behavior when it's serialized to JSON (Inledger_entry
orledger_data
responses, or in the metadata of a SetFee transaction):BaseFee
is serialized as hex despite being an XRP amount (UInt64)ReferenceFeeUnits
,ReserveBase
, andReserveIncrement
are serialized as JSON numbers, not strings as XRP usually is. (This is because they are actually UInt32 types instead of the usual UInt64.)It would be nice to change the binary format of the
FeeSettings
object to make it use the proper data type for XRP amounts in all its XRP fields, but that's harder to fix because it would require an amendment.The text was updated successfully, but these errors were encountered: