Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve serialization of the "FeeSettings" ledger node #3502

Closed
carlhua opened this issue Jul 9, 2020 · 2 comments
Closed

Improve serialization of the "FeeSettings" ledger node #3502

carlhua opened this issue Jul 9, 2020 · 2 comments
Labels
Good First Issue Great issue for a new contributor RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements

Comments

@carlhua
Copy link
Contributor

carlhua commented Jul 9, 2020

The JSON serialization of the "FeeSettings" ledger node is inconsistent:

{
   "BaseFee": "000000000000000A",
   "Flags": 0,
   "LedgerEntryType": "FeeSettings",
   "ReferenceFeeUnits": 10,
   "ReserveBase": 20000000,
   "ReserveIncrement": 5000000,
   "index": "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A651"
}

The BaseFee, ReserveBase, and ReserveIncrement should all be integer strings since they represent XRP.

The ReferenceFeeUnits can stay as a JSON number since it's in fee units, not XRP, so it's limited to 32 bits.

Exported from RIPD-1550
@carlhua carlhua added Good First Issue Great issue for a new contributor Tech Debt Non-urgent improvements RIPD Export Exported from legacy JIRA issue tracking labels Jul 9, 2020
@movitto
Copy link
Contributor

movitto commented Jul 17, 2020

This is a duplicate of #3165

@movitto movitto mentioned this issue Jul 17, 2020
Closed
@carlhua
Copy link
Contributor Author

carlhua commented Jul 17, 2020

Thanks @movitto - closing

@carlhua carlhua closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Great issue for a new contributor RIPD Export Exported from legacy JIRA issue tracking Tech Debt Non-urgent improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@movitto @carlhua