Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should log exception message in several locations #3213

Closed
mellery451 opened this issue Jan 7, 2020 · 2 comments · Fixed by #4400
Closed

Should log exception message in several locations #3213

mellery451 opened this issue Jan 7, 2020 · 2 comments · Fixed by #4400
Assignees
@drlongle
Labels
Good First Issue Great issue for a new contributor

Comments

@mellery451
Copy link
Contributor

There are a number of places that catch exceptions and don't log the exception message (.what()). Consider adding the exception info at these locations:

src/ripple/basics/impl/make_SSLContext.cpp|348 col 9| catch (std::exception const&)
src/ripple/app/misc/impl/Manifest.cpp|151 col 5| catch (std::exception const&)
src/ripple/app/misc/impl/Manifest.cpp|282 col 5| catch (std::exception const&)
src/ripple/app/misc/impl/ValidatorSite.cpp|340 col 5| catch (std::exception &)
src/ripple/app/misc/NetworkOPs.cpp|892 col 5| catch (std::exception const&)
src/ripple/app/consensus/RCLConsensus.cpp|579 col 17| catch (std::exception const&)
src/ripple/app/ledger/impl/TransactionAcquire.cpp|239 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerMaster.cpp|746 col 13| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerMaster.cpp|1098 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerMaster.cpp|1227 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerMaster.cpp|1798 col 13| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerMaster.cpp|2093 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/OpenLedger.cpp|237 col 9| catch(std::exception const&)
src/ripple/app/ledger/Ledger.cpp|841 col 5| catch (std::exception const&)
src/ripple/app/ledger/OpenLedger.h|230 col 9| catch(std::exception const&)
src/ripple/app/ledger/ConsensusTransSetSF.cpp|69 col 9| catch (std::exception const&)
src/ripple/app/tx/impl/apply.cpp|152 col 5| catch (std::exception const&)
src/ripple/shamap/impl/SHAMap.cpp|159 col 13| catch (std::exception const&)
src/ripple/protocol/impl/STValidation.cpp|116 col 5| catch (std::exception const&)
src/ripple/rpc/handlers/PayChanClaim.cpp|83 col 5| catch (std::exception&)
src/ripple/overlay/impl/PeerImp.cpp|1520 col 5| catch (std::exception const&)
src/ripple/overlay/impl/PeerImp.cpp|2307 col 5| catch (std::exception const&)
src/ripple/overlay/impl/PeerImp.cpp|2381 col 5| catch (std::exception const&)

The following locations either don't log at all or need a closer review to decide if the exception message would be useful:

src/ripple/app/consensus/RCLConsensus.cpp|467 col 9| catch (std::exception const&)
src/ripple/app/ledger/impl/BuildLedger.cpp|142 col 13| catch (std::exception const&)
src/ripple/app/ledger/OrderBookDB.cpp|297 col 13| catch (std::exception const&)
src/ripple/app/paths/Pathfinder.cpp|438 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/LedgerToJson.cpp|176 col 5| catch (std::exception const&)
src/ripple/app/ledger/impl/InboundLedgers.cpp|285 col 9| catch (std::exception const&)
src/ripple/protocol/impl/STTx.cpp|199 col 5| catch (std::exception const&)
@mellery451 mellery451 added the Good First Issue Great issue for a new contributor label Jan 7, 2020
@TUNMAY-42
Copy link

hey iam intrested to contribute , kindly assign the task to me ,, and what is the problem statement

@Kinshuk2003
Copy link

hey i am interested to contribute to this anyone can give me just a quick brief so that i can get started

@drlongle drlongle self-assigned this Jan 25, 2023
@drlongle drlongle mentioned this issue Jan 26, 2023
Merged
7 tasks
drlongle added a commit to drlongle/rippled that referenced this issue Mar 29, 2023
@drlongle
Add logging for exceptions (XRPLF#3213)
8e1d824
intelliot pushed a commit that referenced this issue Mar 30, 2023
@drlongle
Add logging for exceptions: (#4400)
8bfdbcb 
Log exception messages at several locations.

Previously, these were locations where an exception was caught, but the
exception message was not logged. Logging the exception messages can be
useful for analysis or debugging. The additional logging could have a
small negative performance impact.

Fix #3213.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drlongle drlongle

Labels
Good First Issue Great issue for a new contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log exception messages in several locations drlongle/rippled
4 participants
@mellery451 @drlongle @TUNMAY-42 @Kinshuk2003