Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deb pkg upgrade process (Version: 1.5 rc1) #3294

Closed
carlhua opened this issue Mar 10, 2020 · 2 comments
Closed

Improve deb pkg upgrade process (Version: 1.5 rc1) #3294

carlhua opened this issue Mar 10, 2020 · 2 comments
Assignees
Labels
CI Continuous Integration Functionality

Comments

@carlhua
Copy link
Contributor

carlhua commented Mar 10, 2020

Issue Description

The current deb pk upgrade process restarts rippled process - it should only upgrade the files without restarting the process

Steps to Reproduce

The moment you do "apt-get install rippled" then apt will download and unpack and then also stop rippled and update the files and then start rippled.

Expected Result

do not stop and restart rippled

Actual Result

rippled is halted and restarted.

Environment

Deb, Ubuntu 16.04 and 18.04

Supporting Files

n/a

@carlhua carlhua added the CI Continuous Integration Functionality label Mar 10, 2020
@MarkusTeufelberger
Copy link
Collaborator

MarkusTeufelberger commented Mar 11, 2020

How do you expect a binary to be updated while it keeps running? Or should the old version keep running after upgrading to the current one?

@mDuo13
Copy link
Collaborator

mDuo13 commented Mar 15, 2021

I think it's probably correct that updating the package restarts the service? I don't like the idea of upgrading the package but then having the old binary continue to run. That sounds like a recipe for version mismatches and hard-to-debug issues.

legleux added a commit to legleux/rippled that referenced this issue Sep 10, 2021
legleux added a commit to legleux/rippled that referenced this issue Sep 13, 2021
legleux added a commit to legleux/rippled that referenced this issue Sep 13, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Sep 28, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Oct 4, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Oct 6, 2021
legleux added a commit to legleux/rippled that referenced this issue Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Functionality
Projects
None yet
Development

No branches or pull requests

4 participants