Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include new validation fields in subscription stream #3797

Closed
wilsonianb opened this issue Mar 18, 2021 · 1 comment
Closed

Include new validation fields in subscription stream #3797

wilsonianb opened this issue Mar 18, 2021 · 1 comment
Labels
Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor

Comments

@wilsonianb
Copy link
Contributor

Summary

Include recently added validation fields in validations subscription stream messages:

  • version
  • cookie
  • validated hash

Motivation

This information is useful for server operators, for developing who are putting together dashboards, and the community at large.

#3291 (comment)

Solution

Add fields to pubValidation

Paths Not Taken
@wilsonianb wilsonianb added the Feature Request Used to indicate requests to add new features label Mar 18, 2021
@nbougalis
Copy link
Contributor

Yeah, those should have been added already. If anyone wants to tackle this, they're welcome to.

@nbougalis nbougalis added Good First Issue Great issue for a new contributor Medium Priority labels Mar 22, 2021
@nbougalis nbougalis mentioned this issue Mar 29, 2021
Closed
7 tasks
scottschurr pushed a commit to scottschurr/rippled that referenced this issue Jun 9, 2021
@nbougalis @scottschurr
Report additional fields in validation stream:
e563f52 
The HardenedValidations amendment introduces additional fields
in validations:

- `sfValidatedHash`, if present, is the hash the of last ledger that
  the validator considers to be fully validated.
- `sfCookie`, if present, is a 64-bit cookie (the default
  implementation selects it randomly at startup but other
  implementations are possible), which can be used to improve the
  detection and classification of duplicate validations.
- `sfServerVersion`, if present, reports the version of the software
  that the validator is running. By surfacing this information,
  server operators gain additional insight about variety of software
  on the network.

If merged, this commit fixes XRPLF#3797 by adding the fields to the
`validations` stream as shown below:

- `sfValidateHash` as `validated_hash`: a 256-bit hex string;
- `sfCookie` as `cookie`: a 64-bit integer as a string; and
- `sfServerVersion` as `server_version`: a 64-bit integer as
  a string.
@scottschurr scottschurr mentioned this issue Jun 9, 2021
Closed
3 tasks
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 21, 2021
@nbougalis @manojsdoshi
Report additional fields in validation stream:
7b5dc0d 
The HardenedValidations amendment introduces additional fields
in validations:

- `sfValidatedHash`, if present, is the hash the of last ledger that
  the validator considers to be fully validated.
- `sfCookie`, if present, is a 64-bit cookie (the default
  implementation selects it randomly at startup but other
  implementations are possible), which can be used to improve the
  detection and classification of duplicate validations.
- `sfServerVersion`, if present, reports the version of the software
  that the validator is running. By surfacing this information,
  server operators gain additional insight about variety of software
  on the network.

If merged, this commit fixes XRPLF#3797 by adding the fields to the
`validations` stream as shown below:

- `sfValidateHash` as `validated_hash`: a 256-bit hex string;
- `sfCookie` as `cookie`: a 64-bit integer as a string; and
- `sfServerVersion` as `server_version`: a 64-bit integer as
  a string.
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 21, 2021
@nbougalis @manojsdoshi
Report additional fields in validation stream:
cae1287 
The HardenedValidations amendment introduces additional fields
in validations:

- `sfValidatedHash`, if present, is the hash the of last ledger that
  the validator considers to be fully validated.
- `sfCookie`, if present, is a 64-bit cookie (the default
  implementation selects it randomly at startup but other
  implementations are possible), which can be used to improve the
  detection and classification of duplicate validations.
- `sfServerVersion`, if present, reports the version of the software
  that the validator is running. By surfacing this information,
  server operators gain additional insight about variety of software
  on the network.

If merged, this commit fixes XRPLF#3797 by adding the fields to the
`validations` stream as shown below:

- `sfValidateHash` as `validated_hash`: a 256-bit hex string;
- `sfCookie` as `cookie`: a 64-bit integer as a string; and
- `sfServerVersion` as `server_version`: a 64-bit integer as
  a string.
scottschurr pushed a commit to scottschurr/rippled that referenced this issue Jul 23, 2021
@nbougalis @scottschurr
Report additional fields in validation stream:
dc6d5cd 
The HardenedValidations amendment introduces additional fields
in validations:

- `sfValidatedHash`, if present, is the hash the of last ledger that
  the validator considers to be fully validated.
- `sfCookie`, if present, is a 64-bit cookie (the default
  implementation selects it randomly at startup but other
  implementations are possible), which can be used to improve the
  detection and classification of duplicate validations.
- `sfServerVersion`, if present, reports the version of the software
  that the validator is running. By surfacing this information,
  server operators gain additional insight about variety of software
  on the network.

If merged, this commit fixes XRPLF#3797 by adding the fields to the
`validations` stream as shown below:

- `sfValidateHash` as `validated_hash`: a 256-bit hex string;
- `sfCookie` as `cookie`: a 64-bit integer as a string; and
- `sfServerVersion` as `server_version`: a 64-bit integer as
  a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Used to indicate requests to add new features Good First Issue Great issue for a new contributor
Projects
None yet
Milestone
No milestone
2 participants
@nbougalis @wilsonianb