-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
“account_tx” with ledger_index_max out of range do not return "lgrIdxMalformed" error.(Version: ["1.9.2"]) #4288
Comments
“account_tx” with the ledger specified by the ledger_index_min does not exist, or if it does exist but the server does not have it should return expected error: lgrIdxMalformed Sample request: Expected Result Actual Result |
“account_tx” with invalid ledger_index returns "invalidParams" instead of "lgrNotFound" error. |
Certain inputs for the AccountTx method should return an error. In other words, an invalid request from a user or client now results in an error message. Since this can change the response from the API, it is an API breaking change. This commit maintains backward compatibility by keeping the existing behavior for existing requests. When clients specify "api_version": 2, they will be able to get the updated error messages. Update unit tests to check the error based on the API version. * Fix XRPLF#4288 * Fix XRPLF#4545
Certain inputs for the AccountTx method should return an error. In other words, an invalid request from a user or client now results in an error message. Since this can change the response from the API, it is an API breaking change. This commit maintains backward compatibility by keeping the existing behavior for existing requests. When clients specify "api_version": 2, they will be able to get the updated error messages. Update unit tests to check the error based on the API version. * Fix XRPLF#4288 * Fix XRPLF#4545
Certain inputs for the AccountTx method should return an error. In other words, an invalid request from a user or client now results in an error message. Since this can change the response from the API, it is an API breaking change. This commit maintains backward compatibility by keeping the existing behavior for existing requests. When clients specify "api_version": 2, they will be able to get the updated error messages. Update unit tests to check the error based on the API version. * Fix XRPLF#4288 * Fix XRPLF#4545
Issue Description
“account_tx” with the ledger specified by the ledger_index_max does not exist, or if it does exist but the server does not have it should return expected error: lgrIdxMalformed
Sample request
{ "method": "account_tx", "params": [ { "account": "r4s7P9WUU6AZ9DB315GWKtBaaDji9Zst8h", "binary": false, "forward": false, "ledger_index_max": 31089994, "ledger_index_min": -1 } ] }
Expected Result
"error": "lgrIdxMalformed"
Actual Result
{ "result": { "account": "r4s7P9WUU6AZ9DB315GWKtBaaDji9Zst8h", "ledger_index_max": 21320746, "ledger_index_min": 21316540, "limit": 0, "status": "success", "transactions": [], "validated": true } }
The text was updated successfully, but these errors were encountered: