Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendations for BUILD.md #4554

Open
intelliot opened this issue Jun 1, 2023 · 2 comments
Open

Recommendations for BUILD.md #4554

intelliot opened this issue Jun 1, 2023 · 2 comments
Labels
Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor

Comments

@intelliot
Copy link
Collaborator

intelliot commented Jun 1, 2023 •
edited
Loading

A few recommendations:

  1. When building on Apple M silicon, I believe that the Conan install option --build missing needs to be changed to just --build.

  2. I recommend adding an example to the options section that shows how to use an option. Perhaps:

cmake -DCMAKE_TOOLCHAIN_FILE: ... -Dassert=ON
  1. One can confirm how options are currently set in CMakeCache.txt

Originally posted by @HowardHinnant in #4514 (review)
@intelliot intelliot added Good First Issue Great issue for a new contributor Documentation README changes, code comments, etc. labels Jun 1, 2023
@AnmolSirola
Copy link

@intelliot Is anyone working on this issue ?

@intelliot
Copy link
Collaborator Author

@AnmolSirola No, not that I am aware of. You are welcome to take it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation README changes, code comments, etc. Good First Issue Great issue for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@intelliot @AnmolSirola