Update BUILD.md #4514
Merged
Update BUILD.md #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
approved these changes
May 19, 2023
intelliot
approved these changes
May 19, 2023
HowardHinnant
approved these changes
May 30, 2023
There was a problem hiding this comment.
A few recommendations:
-
When building on Apple M silicon, I believe that the Conan install option
--build missingneeds to be changed to just--build. -
I recommend adding an example to the options section that shows how to use an option. Perhaps:
cmake -DCMAKE_TOOLCHAIN_FILE: ... -Dassert=ON
- One can confirm how options are currently set in CMakeCache.txt
|
I will be merging this shortly; let's consider Howard's suggestions above for a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR updates the BUILD.md instructions. This mainly fixes formatting and restructures content for better readability and understanding.
Context of Change
This change was prompted by this discussion: #4433
Type of Change