You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the NFTokenAcceptOffer is executed, the transaction succeeds even though the NFToken recipient doesn't have sufficient reserves for the new NFTokenPage.
Without this amendment, an NFTokenAcceptOffer transaction can succeed
even when the NFToken recipient does not have sufficient reserves for
the new NFTokenPage. This allowed accounts to accept NFT sell offers
without having a sufficient reserve. (However, there was no issue in
brokered mode or when a buy offer is involved.)
Instead, the transaction should fail with `tecINSUFFICIENT_RESERVE` as
appropriate. The `fixNFTokenReserve` amendment adds checks in the
NFTokenAcceptOffer transactor to check if the OwnerCount changed. If it
did, then it checks the new reserve requirement.
Fix#4679
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this issue
Jun 12, 2024
…LF#4767)
Without this amendment, an NFTokenAcceptOffer transaction can succeed
even when the NFToken recipient does not have sufficient reserves for
the new NFTokenPage. This allowed accounts to accept NFT sell offers
without having a sufficient reserve. (However, there was no issue in
brokered mode or when a buy offer is involved.)
Instead, the transaction should fail with `tecINSUFFICIENT_RESERVE` as
appropriate. The `fixNFTokenReserve` amendment adds checks in the
NFTokenAcceptOffer transactor to check if the OwnerCount changed. If it
did, then it checks the new reserve requirement.
FixXRPLF#4679
Issue Description
When the
NFTokenAcceptOffer
is executed, the transaction succeeds even though theNFToken
recipient doesn't have sufficient reserves for the newNFTokenPage
.Steps to Reproduce
Expected Result
Should fail with
tecINSUFFICIENT_RESERVE
Actual Result
Transaction successes.
Environment
1.12.0-b3 (
wss://s.devnet.rippletest.net:51233/
)1.11.0 (
wss://testnet.xrpl-labs.com
)Supporting Files
Reserves are checked in
NFTokenMint
.The text was updated successfully, but these errors were encountered: