Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on <ranges> #4787

Closed
Bronek opened this issue Oct 25, 2023 · 0 comments · Fixed by #4788
Closed

Remove dependency on <ranges> #4787

Bronek opened this issue Oct 25, 2023 · 0 comments · Fixed by #4788

Comments

@Bronek
Copy link
Collaborator

Bronek commented Oct 25, 2023

In #4759 I inadvertently managed to sneak in dependency on <ranges> . Given that at this time we want this project to compile on relatively old compilers (gcc 11, clang 13) which may not have this header, this dependency is potentially breaking. Also, the code in question (below) can trivially switch to something else.

Problematic code excerpt

#include <ranges>

auto make_vector(auto const& input) requires std::ranges::range<decltype(input)>
{
    return std::vector(std::ranges::begin(input), std::ranges::end(input));
}
@Bronek Bronek mentioned this issue Oct 25, 2023
12 tasks
intelliot pushed a commit that referenced this issue Oct 30, 2023
Remove dependency on `<ranges>` header, since it is not implemented by
all compilers which we want to support.

This code change only affects unit tests.

Resolve #4787
sophiax851 pushed a commit to sophiax851/rippled that referenced this issue Jun 12, 2024
Remove dependency on `<ranges>` header, since it is not implemented by
all compilers which we want to support.

This code change only affects unit tests.

Resolve XRPLF#4787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant