Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will there be payee and payer that are the same with a transaction? #4858

Closed
xiongjiabing opened this issue Jan 2, 2024 · 7 comments
Closed
Labels
Feature Request Used to indicate requests to add new features

Comments

@xiongjiabing
Copy link

hi team, will there be payee and payer that are the same with a transaction?
Now I've found similar transactions on other networks,e.g. CELO,TIA

Each block contains a large number of such transactions,I worry that XRP will have similar problems

@xiongjiabing xiongjiabing added the Feature Request Used to indicate requests to add new features label Jan 2, 2024
@xiongjiabing
Copy link
Author

And these transactions are very small

@mvadari
Copy link
Collaborator

mvadari commented Jan 2, 2024

You cannot send a Payment transaction to yourself.

@Bronek
Copy link
Collaborator

Bronek commented Jan 2, 2024

Indeed; as I was looking to answer this issue I found that this is enforced in preflight, so the check is very cheap to do. However I also noticed that there's no unit test for this check, will add it.

@Bronek
Copy link
Collaborator

Bronek commented Jan 2, 2024

Test added in #4860

@nixer89
Copy link
Collaborator

nixer89 commented Jan 5, 2024

You cannot send a Payment transaction to yourself.

I think you can send a payment transaction to yourself as long as it crosses offers (currency conversion) and the sent currency does not equal the receiving currency.

@Bronek
Copy link
Collaborator

Bronek commented Jan 5, 2024

You cannot send a Payment transaction to yourself.

I think you can send a payment transaction to yourself as long as it crosses offers (currency conversion) and the sent currency does not equal the receiving currency.

That's true, but it requires a path, hence involvement of other accounts.

@intelliot intelliot changed the title [transaction] (Version: [1.10.0]) will there be payee and payer that are the same with a transaction? Jan 26, 2024
@Bronek
Copy link
Collaborator

Bronek commented Feb 27, 2024

No changes in regard to this issue are planned in the future.

@Bronek Bronek closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

4 participants