[TRIVIAL] Add unit test for redundant payment #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
feature/add_test_redunant_payment
branch
from
c40c91e to
bec1e8f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4860 +/- ##
========================================
Coverage 61.48% 61.49%
========================================
Files 797 797
Lines 70121 70122 +1
Branches 36238 36238
========================================
+ Hits 43114 43119 +5
- Misses 19763 19764 +1
+ Partials 7244 7239 -5 ☔ View full report in Codecov by Sentry. |
|
@intelliot this is ready to merge |
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
If the payee and payer are the same account, then the transaction fails in preflight with temREDUNDANT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The preflight check to enforce that payee and payer must not be the same account have been in rippled at least 9 years, however we do not have unit test for this case. Add it.
Context of Change
Apparently other crypto ledgers are attacked by creating large number of transactions with the same payee and payer. We are immune to this type of attack, but it is not obvious. Let's make it clear and also improve unit test coverage.
Type of Change
.gitignore, formatting, dropping support for older tooling)