Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/range set get pre #2109

Closed
wants to merge 2 commits into from

Conversation

wufeipeng
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2109 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2109   +/-   ##
========================================
  Coverage    68.84%   68.84%           
========================================
  Files          684      684           
  Lines        50367    50367           
========================================
  Hits         34674    34674           
  Misses       15693    15693
Impacted Files Coverage Δ
src/ripple/basics/impl/RangeSet.cpp 77.77% <100%> (+5.55%) ⬆️
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%) ⬇️
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%) ⬇️
src/ripple/server/impl/BaseWSPeer.h 67.5% <0%> (-0.63%) ⬇️
src/ripple/core/impl/JobQueue.cpp 85.71% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbc5a5...43bc5c9. Read the comment docs.

@bachase
Copy link
Collaborator

bachase commented May 9, 2017

Thanks for spotting @wufeipeng. Fortunately, rippled is not currently using getPrev anywhere at this time. Before considering a merge, I want to investigate replacing RangeSet with Boost ICL as an alternate. I'll post back here once done evaluating that option.

@bachase bachase mentioned this pull request May 10, 2017
@bachase
Copy link
Collaborator

bachase commented May 10, 2017

Thanks again for your contribution, but I believe we will go with #2113 instead. Better to remove code that is not needed or used!

@bachase bachase closed this May 10, 2017
@wufeipeng
Copy link
Author

understand, that is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants