Add zlib to libs when finding openssl #2187
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2187 +/- ##
===========================================
- Coverage 69.96% 69.94% -0.02%
===========================================
Files 689 689
Lines 50734 50734
===========================================
- Hits 35495 35488 -7
- Misses 15239 15246 +7
Continue to review full report at Codecov.
|
|
This allows me to successfully build rippled on Fedora26 with |
There was a problem hiding this comment.
Changes look good. Windows doesn't support static builds, but the non-static builds are fine. I abused several different combinations of options under linux, and they all worked fine as well. 👍
I noticed the Travis build failed, so I restarted it. However, I don't anticipate it succeeding. Please rebase to the latest beta, which has Travis fixes, so we can confirm CI success.
wilsonianb
added
the
Passed
FIXES: (RIPD-1496): if openssl is configured with compression support AND you link to the static lib, you are going to need to libk to zlib. Fundamentally the CMake finder should take care of this (as described in https://gitlab.kitware.com/cmake/cmake/issues/16885), but we work around it here by adding zlib explicitly. Update beast error test for OpenSSL 1.1.0
|
Merged as 36423a5 |
FIXES: (RIPD-1496):
if openssl is configured with compression support AND you link
to the static lib, you are going to need to link to zlib. Fundamentally
the CMake finder should take care of this (as described in
https://gitlab.kitware.com/cmake/cmake/issues/16885), but we
work around it here by adding zlib explicitly.