Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial: Fix typo in TxQ log message #2218

Closed
wants to merge 1 commit into from
Closed

Trivial: Fix typo in TxQ log message #2218

wants to merge 1 commit into from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Aug 29, 2017

No description provided.

@ximinez ximinez requested a review from seelabs August 29, 2017 17:59
seelabs
seelabs reviewed Aug 29, 2017
View reviewed changes
src/ripple/app/misc/impl/TxQ.cpp
@@ -1027,7 +1027,7 @@ TxQ::apply(Application& app, OpenView& view,
JLOG(j_.warn()) <<
"Removing last item of account " <<
lastRIter->account <<
"from queue with average fee of" <<
" from queue with average fee of " <<
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there should be a space at the end, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the next line of code starts with a number. This is what it looks like now (from #2215):

2017-Aug-28 22:47:24 TxQ:WRN Removing last item of account rfepxFxQKMSwn1otQRk35TgXbfLX6p8JBXfrom queue with average fee of27297 in favor of 10982E55CC5219B0B4B90B5B2D205965196171F8C8A720800EF14D6B9F789C21 with fee of 446796

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, I misread the code.

@seelabs
Copy link
Collaborator

seelabs commented Aug 29, 2017

👍

@codecov-io
Copy link

Codecov Report

Merging #2218 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2218      +/-   ##
===========================================
- Coverage    70.05%   70.04%   -0.01%     
===========================================
  Files          689      689              
  Lines        50724    50724              
===========================================
- Hits         35533    35530       -3     
- Misses       15191    15194       +3
Impacted Files Coverage Δ
src/ripple/app/misc/impl/TxQ.cpp 96.03% <100%> (ø) ⬆️
src/ripple/protocol/impl/STVar.cpp 85.71% <0%> (-2.6%) ⬇️
src/ripple/core/impl/Workers.cpp 98.86% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589570d...7c832c3. Read the comment docs.

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 29, 2017
@seelabs
Copy link
Collaborator

seelabs commented Sep 1, 2017

In 0.80.0-rc2

@seelabs seelabs closed this Sep 1, 2017
@ximinez ximinez deleted the txq-typo branch September 1, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seelabs seelabs seelabs approved these changes

Assignees

@seelabs seelabs

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ximinez @seelabs @codecov-io