Convert more timing code to <chrono> #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HowardHinnant
commented
Sep 29, 2017
HowardHinnant
commented
- LoadMonitor
- Entry
- Import
Codecov Report
@@ Coverage Diff @@
## develop #2237 +/- ##
===========================================
- Coverage 70.11% 70.08% -0.03%
===========================================
Files 689 689
Lines 50800 50800
===========================================
- Hits 35617 35602 -15
- Misses 15183 15198 +15
Continue to review full report at Codecov.
|
seelabs
approved these changes
Oct 2, 2017
src/ripple/app/main/Application.cpp
Outdated
|
|
||
| lastSample_ = ms; | ||
|
|
||
| if (ms.count() >= 10) | ||
| if (ms >= 10ms) |
There was a problem hiding this comment.
Nit: We have a variable ms and a suffix ms, so we're seeing code like ms >= 10ms. The code is clear, however I it does seem a little weird. Maybe rename the ms variable?
src/ripple/core/impl/JobQueue.cpp
Outdated
|
|
||
| if (ms.count() >= 10) | ||
| if (ms >= 10ms) |
There was a problem hiding this comment.
Same nit here: we have both a var ms and a suffix ms
bachase
approved these changes
Oct 2, 2017
src/ripple/core/JobTypes.h
Outdated
| add( jtNS_ASYNC_READ, "AsyncReadNode", 0, true, 0, 0); | ||
| add( jtNS_WRITE, "WriteNode", 0, true, 0, 0); | ||
| add( jtPACK, "makeFetchPack", 1, false, 0ms, 0ms); | ||
| add( jtPUBOLDLEDGER, "publishAcqLedger", 2, false, 10000ms, 15000ms); |
There was a problem hiding this comment.
Nice readability improvement!
HowardHinnant
added
the
Passed
HowardHinnant
force-pushed
the
chrono_clean
branch
from
7630c58 to
3e874d3
Compare
|
Rebased to 0.80.0 and squashed. |
* LoadMonitor * Entry * Import
HowardHinnant
force-pushed
the
chrono_clean
branch
from
3e874d3 to
48e67f6
Compare
|
Rebased to 0.80.1 |
|
In 0.90.0-b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.