-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make quorum unreachable if validator list expires (RIPD-1539) #2240
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -235,7 +235,7 @@ ValidatorList::applyList ( | |
(iOld != oldList.end () && *iOld < *iNew)) | ||
{ | ||
// Decrement list count for removed keys | ||
if (keyListings_[*iOld] == 1) | ||
if (keyListings_[*iOld] <= 1) | ||
keyListings_.erase (*iOld); | ||
else | ||
--keyListings_[*iOld]; | ||
|
@@ -395,6 +395,9 @@ ValidatorList::removePublisherList (PublicKey const& publisherKey) | |
--iVal->second; | ||
} | ||
|
||
iList->second.list.clear(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without this call to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good observation. This added test fails without the |
||
iList->second.available = false; | ||
|
||
return true; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all published lists required to have an expiration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
https://github.com/ripple/rippled/blob/3e5490ef6db9cbc3abdff04655d80952b288d097/src/ripple/app/misc/impl/ValidatorList.cpp#L302-L313