Log error conditions when fetching validator list.

[mtrippled]

This would have saved some time isolating a problem with Ubuntu using our statically linked redhat ssl lib.

[MarkusTeufelberger]

You could also link against the native library that is installed... ;-)

[codecov-io]

Codecov Report

Merging #2243 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2243      +/-   ##
===========================================
- Coverage    70.12%   70.08%   -0.04%     
===========================================
  Files          689      689              
  Lines        50800    50810      +10     
===========================================
- Hits         35621    35612       -9     
- Misses       15179    15198      +19

Impacted Files	Coverage Δ
src/ripple/app/misc/impl/ValidatorSite.cpp	73.2% <0%> (-5.12%)	⬇️
src/ripple/server/impl/BaseHTTPPeer.h	86.95% <0%> (-3.11%)	⬇️
src/ripple/protocol/impl/STVar.cpp	85.71% <0%> (-2.6%)	⬇️
src/ripple/app/misc/SHAMapStoreImp.cpp	78.92% <0%> (-1.03%)	⬇️
src/ripple/protocol/impl/Serializer.cpp	69.96% <0%> (-0.35%)	⬇️
src/ripple/basics/DecayingSample.h	86.11% <0%> (+8.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5490e...0d59e81. Read the comment docs.

[wilsonianb]

👍 LGTM

[ximinez]

Good simple change. I left one future-proofing suggestion, but it's not a deal breaker. 👍

[ximinez]

If there is any chance of ListDisposition getting additional values in the future, I suggest adding a final case.

else
{
  BOOST_ASSERT(false);
}

That would make it a little more likely that we catch missing cases like this in the future, and gets optimized out in release builds.

[mtrippled]

fixed

[mtrippled]

I'm marking this passed: both reviewers 👍, it passes my local unit tests. But continuous-integration/travis-ci/pr has failed several times with timeouts in building, so Travis seems unusable at this point.

[bachase]

Merged as 8f347a5