SSL fixes for validator list (RIPD-1558) #2275
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| //------------------------------------------------------------------------------ | ||
| /* | ||
| This file is part of rippled: https://github.com/ripple/rippled | ||
| Copyright (c) 2016 Ripple Labs Inc. | ||
|
|
||
|
|
||
| Permission to use, copy, modify, and/or distribute this software for any | ||
| purpose with or without fee is hereby granted, provided that the above | ||
| copyright notice and this permission notice appear in all copies. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
| WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
| MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
| ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
| WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
| ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
| OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | ||
| */ | ||
| //============================================================================== | ||
|
|
||
| #ifndef RIPPLE_NET_REGISTER_SSL_CERTS_H_INCLUDED | ||
| #define RIPPLE_NET_REGISTER_SSL_CERTS_H_INCLUDED | ||
|
|
||
| #include <boost/asio/ssl/context.hpp> | ||
|
|
||
| namespace ripple { | ||
| /** Register default SSL certificates. | ||
|
|
||
| Register the system default SSL root certificates. On linux/mac, | ||
| this just calls asio's `set_default_verify_paths` to look in standard | ||
| operating system locations. On windows, it uses the OS certificate | ||
| store accessible via CryptoAPI. | ||
| */ | ||
| void | ||
| registerSSLCerts(boost::asio::ssl::context&, boost::system::error_code&); | ||
|
|
||
| } // namespace ripple | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| //------------------------------------------------------------------------------ | ||
| /* | ||
| This file is part of rippled: https://github.com/ripple/rippled | ||
| Copyright (c) 2012, 2013 Ripple Labs Inc. | ||
|
|
||
| Permission to use, copy, modify, and/or distribute this software for any | ||
| purpose with or without fee is hereby granted, provided that the above | ||
| copyright notice and this permission notice appear in all copies. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
| WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
| MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
| ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
| WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
| ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
| OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | ||
| */ | ||
| //============================================================================== | ||
| #include <BeastConfig.h> | ||
| #include <ripple/net/RegisterSSLCerts.h> | ||
| #if BEAST_WINDOWS | ||
|
There was a problem hiding this comment. It looks like There was a problem hiding this comment. I can use boost predef instead. |
||
| #include <wincrypt.h> | ||
| #endif | ||
|
|
||
| namespace ripple { | ||
|
|
||
| void | ||
| registerSSLCerts(boost::asio::ssl::context& ctx, boost::system::error_code& ec) | ||
| { | ||
| #if BEAST_WINDOWS | ||
| HCERTSTORE hStore = CertOpenSystemStore(0, "ROOT"); | ||
| if (hStore == NULL) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| X509_STORE* store = X509_STORE_new(); | ||
| PCCERT_CONTEXT pContext = NULL; | ||
| while ((pContext = CertEnumCertificatesInStore(hStore, pContext)) != NULL) | ||
| { | ||
| X509* x509 = d2i_X509( | ||
| NULL, | ||
| (const unsigned char**)&pContext->pbCertEncoded, | ||
|
There was a problem hiding this comment.
|
||
| pContext->cbCertEncoded); | ||
| if (x509 != NULL) | ||
| { | ||
| X509_STORE_add_cert(store, x509); | ||
|
There was a problem hiding this comment. I'm not sure how this would fail, but should we log if it does? There was a problem hiding this comment. Probably worth doing. I'll look into making an error_code. |
||
| X509_free(x509); | ||
| } | ||
| } | ||
|
|
||
| CertFreeCertificateContext(pContext); | ||
|
There was a problem hiding this comment. Isn't |
||
| CertCloseStore(hStore, 0); | ||
|
|
||
| SSL_CTX_set_cert_store(ctx.native_handle(), store); | ||
|
There was a problem hiding this comment. Just to confirm, the reason we don't use
There was a problem hiding this comment. Correct. I believe since we create the There was a problem hiding this comment. Also, it looks like the reference counted version is not available in the 1.0.* versions we are using. |
||
| #else | ||
|
|
||
| ctx.set_default_verify_paths(ec); | ||
| #endif | ||
| } | ||
|
|
||
| } // namespace ripple | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: misaligned