Update Visual Studio build instructions #2355
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| { | ||
| // See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file. | ||
| "configurations": [ | ||
| { | ||
| "name": "x64-Debug", | ||
| "generator": "Visual Studio 15 2017 Win64", | ||
| "configurationType": "Debug", | ||
| "inheritEnvironments": [ "msvc_x64_x64" ], | ||
| "buildRoot": "${thisFileDir}\\build\\${name}", | ||
| "cmakeCommandArgs": "", | ||
| "buildCommandArgs": "-v:minimal", | ||
| "ctestCommandArgs": "", | ||
| "variables": [ | ||
| { | ||
| "name": "BOOST_ROOT", | ||
| "value": "C:\\lib\\boost_1_66_0" | ||
|
There was a problem hiding this comment. I don't love that we're hard coding the boost version here. Is there a better way? Maybe just There was a problem hiding this comment. I agree and that was part of my concern I wrote about in the first comment. Perhaps we just recommend |
||
| }, | ||
| { | ||
| "name": "OPENSSL_ROOT", | ||
| "value": "C:\\lib\\OpenSSL-Win64" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "x64-Release", | ||
| "generator": "Visual Studio 15 2017 Win64", | ||
| "configurationType": "Release", | ||
| "inheritEnvironments": [ "msvc_x64_x64" ], | ||
| "buildRoot": "${thisFileDir}\\build\\${name}", | ||
| "cmakeCommandArgs": "", | ||
| "buildCommandArgs": "-v:minimal", | ||
| "ctestCommandArgs": "", | ||
| "variables": [ | ||
| { | ||
| "name": "BOOST_ROOT", | ||
| "value": "C:\\lib\\boost_1_66_0" | ||
| }, | ||
| { | ||
| "name": "OPENSSL_ROOT", | ||
| "value": "C:\\lib\\OpenSSL-Win64" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
There was a problem hiding this comment. Nit. Add a carriage return for git happiness. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
msvc_x64_x64correct? I usemsvc_x64.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they added it after we started using it https://docs.microsoft.com/en-us/cpp/ide/cmake-tools-for-visual-cpp.