Remove cmake conditional that could never be true

[MarkusTeufelberger]

Boost >= 1.67 is required, the check was for boost versions <= 1.66

[ripplelabs-jenkins]

Thank you for your submission. It will be reviewed soon and submitted for processing in CI.

[nbougalis]

Pending CI, 👍

[seelabs]

👍 LGTM

[ripplelabs-jenkins]

Jenkins Build Summary

Built from this commit

Built at 20180705 - 22:39:32

Test Results

Build Type	Log	Result	Status
rpm	logfile	1034 cases, 0 failed, t: n/a	PASS ✅
gcc.release.unity -Dassert=true, MANUAL_TESTS=true	logfile	1101 cases, 0 failed, t: 799s	PASS ✅
docs	logfile	1 cases, 0 failed, t: 3s	PASS ✅
coverage	logfile	1035 cases, 0 failed, t: 690s	PASS ✅
clang.debug.unity	logfile	1035 cases, 0 failed, t: 251s	PASS ✅
msvc.debug	logfile	1032 cases, 0 failed, t: 566s	PASS ✅
clang.debug.nounity	logfile	1033 cases, 0 failed, t: 148s	PASS ✅
clang.debug.unity, PARALLEL_TESTS=false	logfile	1035 cases, 0 failed, t: 490s	PASS ✅
gcc.debug.unity	logfile	1035 cases, 0 failed, t: 249s	PASS ✅
gcc.debug.nounity	logfile	1033 cases, 0 failed, t: 294s	PASS ✅
clang.release.unity -Dassert=true	logfile	1034 cases, 0 failed, t: 337s	PASS ✅
gcc.release.unity -Dassert=true	logfile	1034 cases, 0 failed, t: 354s	PASS ✅
gcc.debug.unity -Dstatic=true	logfile	1035 cases, 0 failed, t: 248s	PASS ✅
msvc.debug, PROJECT_NAME=rippled_classic	logfile	1032 cases, 0 failed, t: 1234s	PASS ✅
msvc.release	logfile	1031 cases, 0 failed, t: 514s	PASS ✅

[codecov-io]

Codecov Report

Merging #2618 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2618      +/-   ##
===========================================
- Coverage    70.83%   70.82%   -0.02%     
===========================================
  Files          698      698              
  Lines        54367    54367              
===========================================
- Hits         38510    38504       -6     
- Misses       15857    15863       +6

Impacted Files	Coverage Δ
src/ripple/server/impl/BaseHTTPPeer.h	87.65% <0%> (-3.09%)	⬇️
src/ripple/protocol/impl/STVar.cpp	86.07% <0%> (-2.54%)	⬇️
src/ripple/app/misc/SHAMapStoreImp.cpp	75.29% <0%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381a1b9...aa4e3a9. Read the comment docs.

[mellery451]

this is fine, but will be obviated by #2579

[MarkusTeufelberger]

@mellery451 - then it can be closed of course once #2579 is merged, it was just something that caught my eye when I was looking over the boost requirement code in CMake.