Update RocksDB to 6.5: #3244
Closed
Update RocksDB to 6.5: #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@movitto I've also added a build fix here for fedora systems - any feedback appreciated |
|
@mellery451 gave it a test locally and yes, changing lib to ${CMAKE_INSTALL_LIBDIR} in Protobuf.cmake seemed to have the intended effect, the Fedora build now succeeds. Please note I didn't dive into the other changes extensively though. |
movitto
reviewed
Feb 5, 2020
* update EP and find package requirements * minor protobuf/libarchive build fixes * change travis release builds to nounity to ameliorate vm memory exhaustion. FIXES: XRPLF#3223, XRPLF#3232
mellery451
requested review from
nbougalis
and removed request for
manojsdoshi
carlhua
requested review from
miguelportilla
and removed request for
jwbusch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #3223, #3232