Make TicketBatch a SupportedAmendment so it can be enabled. #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed workarounds that are no longer needed in unit tests.
intelliot
approved these changes
Jan 4, 2021
scottschurr
force-pushed
the
enable-ticket-batch
branch
from
a20381d to
19c316b
Compare
|
Rebased to 1.7.0-b9 with no conflicts. |
Merged
pwang200
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
TicketBatchhas been in the code base for a while, but it has not been part of theSupportedAmendments. This was to prevent accidental enablement.Since we're thinking that it may make sense to enable
TicketBatchafter the release of 1.7.0 this commit adds it toSupportedAmendments. The commit also removes a number of workarounds in the unit tests. The workarounds are no longer needed now thatTicketBatchis inSupportedAmendments.This commit does not to be reflected in the release notes, unless it is to note that
TicketBatchis aSupportedAmendmentwith all of the attendant risks and benefits 😉Type of Change
Future Tasks
Shepherd the
TicketBatchamendment once it attains 80% support on the network.