Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix idle peer deletion timer #3756

Closed
wants to merge 1 commit into from

Conversation

gregtatcam
Copy link
Collaborator

High Level Overview of Change

Increments OverlayImpl::timer_count_, so that idle peer deletion is checked once every 4 seconds.

Context of Change

This PR fixes #3754, which was introduced in 1.7.0-b5.

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ximinez ximinez self-requested a review February 4, 2021 17:51
Copy link
Contributor

@miguelportilla miguelportilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Feb 4, 2021
@manojsdoshi manojsdoshi mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increment timer count in the OverlayImpl::on_timer()
5 participants