Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #3799

Closed
wants to merge 1 commit into from
Closed

Remove unused code #3799

wants to merge 1 commit into from

Conversation

nbougalis
Copy link
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@nbougalis nbougalis added Tech Debt Non-urgent improvements Low Priority labels Mar 21, 2021
scottschurr
scottschurr approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

intelliot
intelliot approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that this is getting rid of Tuning.h... then I learned that there are many different files called Tuning.h and this is only one of them :)

@scottschurr scottschurr added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 12, 2021
This was referenced Jun 2, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr approved these changes

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

@intelliot intelliot intelliot approved these changes

Assignees

@thejohnfreeman thejohnfreeman

@scottschurr scottschurr

Labels
Low Priority Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Tech Debt Non-urgent improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbougalis @intelliot @thejohnfreeman @scottschurr