Proposed 1.8.0-b2 #3807
Closed
Proposed 1.8.0-b2 #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NetClock::rep is uint32_t and can be error-prone when used with subtraction. * Fixes XRPLF#3656
* The std::less and std::equal_to comparators have [[nodiscard]], which conflicts with boost::bimap validations.
scottschurr
reviewed
Apr 1, 2021
| @@ -80,8 +79,7 @@ class ProtocolVersion_test : public beast::unit_test::suite | |||
| { | |||
| testcase("Protocol version negotiation"); | |||
|
|
|||
| BEAST_EXPECT( | |||
| negotiateProtocolVersion("RTXP/1.2") == make_protocol(1, 2)); | |||
| BEAST_EXPECT(negotiateProtocolVersion("RTXP/1.2") == boost::none); | |||
There was a problem hiding this comment.
Change boost::none to std::nullopt.
|
This is not building for me on MacOS. The ProtocolVersion_test.cpp file in this commit needs to be patched: 92a9c8c On line 82 change |
scottschurr
reviewed
Apr 1, 2021
Comment on lines
+542
to
+543
| using namespace boost::filesystem; | ||
| path dbPath = setup.dataDir / TxDBName; |
There was a problem hiding this comment.
The boost::filesystem::path is hidden by the declaration of namespace ripple::path in src/ripple/app/paths/Types.h and elsewhere. Replace these two lines with
boost::filesystem::path dbPath = setup.dataDir / TxDBName;
|
The unity build is not working for me either. The RelationalDBInterface pull request (#3590) needs a fix on line 542 of RelationalDBInterface_plobal.cpp. Replace with Here's a link to the comment: 5d7f0f8#r605808653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged this PR will:
close #3787
close #3774
close #3786
close #3785
close #3784
close #3791
close #3590
close #3793