Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Future proof rippled by changing variable name 'requires' to 'require' #3821

Closed
wants to merge 1 commit into from

Conversation

r0bertz
Copy link
Contributor

@r0bertz r0bertz commented Apr 14, 2021

'requires' is a keyword in C++20.

https://en.cppreference.com/w/cpp/keyword/requires

This is the least intrusive change. Another option is to rename the require class (and the associated variable name) to something else. If the latter is desired, I will make the change. Please let me know what you think. Thanks!

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing this issue, and your submission to resolve it. These changes look good to me.

@scottschurr scottschurr self-requested a review April 28, 2021 16:41
@scottschurr scottschurr self-assigned this Apr 28, 2021
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scottschurr scottschurr added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 28, 2021
This was referenced Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants